Bug Layers stop responding - suspended stacks

Discussion in 'Workshop Plus (BUG Reporting Area)' started by Cranky Cat, Nov 27, 2018.

Tags:
  1. Cranky Cat

    Cranky Cat Active Member Patreon Supporter Community Rockstar

    Joined:
    Sep 16, 2017
    Messages:
    299
    Likes Received:
    133

    I know this won't be a particularly helpful bug report since I don't know what I did to cause it. However, I've had to go back to an older save when it did happen. Perhaps someone else can add something if they've had the same issue. It's the worst for me since I don't know that the layers are in this state until I try to use them so I could lose lots of time.

    After not using layers for a while I sometimes try to create a layer only to have nothing seem happen. The hotkey sound doesn't play. Naturally I press it again since sometimes keystrokes seem to not work the first time. If I wait a really long time the key sound may play but I may not be in workshop mode anymore and it'll give the message about hotkeys only being available in workshop mode.

    If I look in the save file with ReSaver (Fallrim Tools) then I see suspended stacks, possibly one per command which is stuck. Some are just STACK and an address while others are STACK workshopplus:layermanager and the appropriate key event in the function message data.

    The active scripts have the instances of the workshopplus:layermanager as well as several TERMINATED scripts which seem to match the stack.

    The papyrus log has several messages similar to these:
    [11/27/2018 - 07:06:54PM] error: (FF097560): cannot enable a deleted object.
    stack:
    [ (FF097560)].ObjectReference.Enable() - "<native>" Line ?
    [ (FF0955E6)].simsettlements:simplot.SafeDelete() - "<unknown file>" Line ?
    [ (FF0955E6)].simsettlements:simplot.DeleteStageModel() - "<unknown file>" Line ?
    [ (FF0955E6)].AutoBuilder:AutoBuildPlot.OnTimer() - "<unknown file>" Line ?
    [ (FF0955E6)].simsettlements:simplot.OnTimer() - "<unknown file>" Line ?
    [11/27/2018 - 07:06:54PM] error: (FF0975CE): the animation graph (Workshop) cannot currently process event "Reset".
    stack:
    [ (FF0975CE)].SimSettlements:ASAMSensor.PlayAnimation() - "<native>" Line ?
    [ (FF08BA76)].simsettlements:simplot.DisconnectFromGrid() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.ObjectSpawned() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.UpdateIndicators() - "<unknown file>" Line ?
    [ (FF08BA76)].AutoBuilder:AutoBuildPlot.SetLevel() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.SetLevel() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.AdvanceLevel() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.setStage() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.AdvanceStage() - "<unknown file>" Line ?
    [ (FF08BA76)].AutoBuilder:AutoBuildPlot.OnTimer() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.OnTimer() - "<unknown file>" Line ?
    [11/27/2018 - 07:06:55PM] error: (FF0975CE): the animation graph (Workshop) cannot currently process event "TurnOn".
    stack:
    [ (FF0975CE)].SimSettlements:ASAMSensor.PlayAnimation() - "<native>" Line ?
    [ (FF0975CE)].SimSettlements:ASAMSensor.OnPowerOn() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.ObjectSpawned() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.UpdateIndicators() - "<unknown file>" Line ?
    [ (FF08BA76)].AutoBuilder:AutoBuildPlot.SetLevel() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.SetLevel() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.AdvanceLevel() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.setStage() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.AdvanceStage() - "<unknown file>" Line ?
    [ (FF08BA76)].AutoBuilder:AutoBuildPlot.OnTimer() - "<unknown file>" Line ?
    [ (FF08BA76)].simsettlements:simplot.OnTimer() - "<unknown file>" Line ?
     
  2. kinggath

    kinggath Well-Known Member Staff Member Administrator Moderator Verified Builder

    Joined:
    May 8, 2017
    Messages:
    3,472
    Likes Received:
    2,900

    Do you have any saves in this state? Of all the bug reports you've posted - this one concerns me the most because it could be causing some of the others.
     
  3. Cranky Cat

    Cranky Cat Active Member Patreon Supporter Community Rockstar

    Joined:
    Sep 16, 2017
    Messages:
    299
    Likes Received:
    133

    I should have save one but didn't since I had to roll back. I wrote over them before my next backup I'm afraid. I'll save the next one although I have so many mods I'm not sure you'll be able to load it.

    It looks like I tried to work with layers while plots were upgrading or refreshing although since I didn't notice when it first started I can't be certain what the trigger was.
     
  4. kinggath

    kinggath Well-Known Member Staff Member Administrator Moderator Verified Builder

    Joined:
    May 8, 2017
    Messages:
    3,472
    Likes Received:
    2,900

    This should be largely solved in the next patch. I'm disabling the automatic adding of all items in a settlement to the Default layer. This was causing a huge backlog of requests which result in stack dumps.

    After the next patch, adding items to the default layer that were already there before you arrived at the settlement, or from before installing WS+ will require activating a tool in the holotape. For most people this won't really be necessary at all.
     
    Cranky Cat likes this.
  5. Cranky Cat

    Cranky Cat Active Member Patreon Supporter Community Rockstar

    Joined:
    Sep 16, 2017
    Messages:
    299
    Likes Received:
    133

    Great, thanks!
     
  6. Cranky Cat

    Cranky Cat Active Member Patreon Supporter Community Rockstar

    Joined:
    Sep 16, 2017
    Messages:
    299
    Likes Received:
    133

    Unfortunately, my layers are broken atm. I'll check after I sort it out or go back to a previous save.

    All I noticed in-game is a "twang" sound effect while building in the default layer only. Now the new layer hotkey doesn't respond. They don't seem to clear up.

    I have a bunch of terminated and WorkshopPlus:Layermanager active scripts with OnMenuOpenCloseEvent() / ClearAllHighlighting() / HighlightLayerItems() / GetLinkedRef()

    [​IMG]
    Edit: The layer managers have parents of workshopframework:mainthreadrunner.RunRemoteFunctionThread() and workshopplus.layermanager.CallFunction() so I guess that's what actually gets spammed for some reason.
     
  7. Cranky Cat

    Cranky Cat Active Member Patreon Supporter Community Rockstar

    Joined:
    Sep 16, 2017
    Messages:
    299
    Likes Received:
    133

    I have to be careful to listen for the "twang" because that means I have to go back to a previous save. The last time it happened I wasn't using layers and was just placing a recreational plot. When the plot materialized with the for-sale sign and building materials I heard the sound and saved. I was working in the default layer with no other layers active and didn't accidentally hit another hotkey which I previously suspected.

    When I checked the save I see this (click for full size)

    [​IMG]

    I'm using the current 3-in-1 v3.5.2, WS+ 1.04, and WF 1.0.8a with the current UFOP.
     
  8. Cranky Cat

    Cranky Cat Active Member Patreon Supporter Community Rockstar

    Joined:
    Sep 16, 2017
    Messages:
    299
    Likes Received:
    133

    Edit: I changed it back to "Bug" since it still occurs. I hope this isn't bad form.

    What I *think* causes this is actually exiting workshop mode and then re-entering workshop mode before the layer cleanup is finished. I believe having Faster Workshop allows this to happen since it's pretty much immediate.

    Currently, I've been avoiding this by making sure I don't re-enter workshop mode while the hud display is showing.

    To test:
    1. Check your save with Fallrim Tools (resaver) before starting and make sure you don't already have suspended stacks and the WorkshopPlus:Layermanager running.
    2. Optionally, wait until lots of SS scripts are already running or start some if you know how. I think this makes the problem more likely to occur.
    3. Make sure the option to display the layer hud only in workshop mode it set.
    4. Create at least one new layer.
    5. Verify that you can switch between them with no issues. If it's really laggy already there may be scripts running in the background, already be issues in the save or maybe the machine is slow. Mine is instant when SS scripts aren't running.
    6. Exit the workshop mode. It generally takes a few seconds for the layer hud to fade out which, to me, means it finished whatever it was doing.
    7. After exiting, immediately go back into workshop mode.
    8. Build some things, etc. See if the layer switching is laggy.
    9. Exit workshop mode.
    10. Save the test game and use Fallrim Tools (resaver) to look for several instances of the WorkshopPlus:Layermanager and suspended stacks.
     
    RayBo likes this.

Share This Page