Question Auto-assignment still happening after disabling in MCM

[Tron91]

@kinggath
Found this block of code in WorkshopParentScript.psc

Spoiler

Bool Property AutoAssignBeds
    Bool Function Get()
        return (WSFW_Setting_AutoAssignBeds.GetValue() == 1)
    EndFunction
   
    Function Set(Bool aValue)
        if(aValue)
            WSFW_Setting_AutoAssignBeds.SetValue(1)
        else
            WSFW_Setting_AutoAssignBeds.SetValue(0)
        endif
    EndFunction
EndProperty       

Bool Property AutoAssignFood
    Bool Function Get()
        return (WSFW_Setting_AutoAssignFood.GetValue() == 1.0)
    EndFunction
   
    Function Set(Bool aValue)
        if(aValue)
            WSFW_Setting_AutoAssignFood.SetValue(1)
        else
            WSFW_Setting_AutoAssignFood.SetValue(0)
        endif
    EndFunction
EndProperty   

Bool Property AutoAssignDefense
    Bool Function Get()
        return (WSFW_Setting_AutoAssignDefense.GetValue() == 1.0)
    EndFunction
   
    Function Set(Bool aValue)
        if(aValue)
            WSFW_Setting_AutoAssignDefense.SetValue(1)
        else
            WSFW_Setting_AutoAssignDefense.SetValue(0)
        endif
    EndFunction
EndProperty

Is that intentional? I mean the return values assigned to 1?

Edit:
Seems auto-assignment problems got fixed after I deleted the "== 1" entries and recompiled the script.

 

[Praetoriax]

I reported this here:

Possible Auto Assign issue · Issue #86 · kinggath/WorkshopFramework

In NPCManager AddNewActorToWorkshop it does not check for (WSFW_Setting_AutoAssign_Beds.GetValueInt() == 1) as Bool before calling TryToAssignBeds WorkshopFramework/Scripts/Source/User/WorkshopFram...

github.com

I also found a bug in the SS2 code. It is submitted as issue #596

It would seem that was the issue, as for the last few patches (up to 2.0.0L) it seems to be resolved!